-
-
Notifications
You must be signed in to change notification settings - Fork 9
GH-334 Folia pearl fix #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… runFolia to runPlugin configuration
Summary of ChangesHello @CitralFlo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue on Folia servers where self-inflicted damage, such as from ender pearls, could erroneously trigger combat tagging due to limitations in damage source identification. The changes introduce a robust, cached mechanism for detecting the Folia environment and a new configurable option to prevent players from being tagged by their own actions, thereby enhancing the plugin's compatibility and accuracy on Folia platforms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Folia compatibility by refactoring environment detection into a dedicated FoliaChecker utility class. It also adds a new configuration option to prevent self-tagging on Folia servers and updates the build configuration to support Folia. The changes are well-structured and address the reported issue.
I cannot get damage source on Folia:

Damage inflicted is marked as player inflicting damage without source - source unable to retrieve by API.