Skip to content

Conversation

@CitralFlo
Copy link
Member

I cannot get damage source on Folia:
image
Damage inflicted is marked as player inflicting damage without source - source unable to retrieve by API.

@CitralFlo CitralFlo changed the title Folia pearl fix GH-334 Folia pearl fix Jan 30, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @CitralFlo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue on Folia servers where self-inflicted damage, such as from ender pearls, could erroneously trigger combat tagging due to limitations in damage source identification. The changes introduce a robust, cached mechanism for detecting the Folia environment and a new configurable option to prevent players from being tagged by their own actions, thereby enhancing the plugin's compatibility and accuracy on Folia platforms.

Highlights

  • Folia Self-Tagging Prevention: Introduced a new configuration option, stopFoliaFromSelfTagging, which, when enabled, prevents players on Folia servers from being combat-tagged by self-inflicted damage sources such as ender pearls or arrows. This addresses an issue where damage source retrieval on Folia could lead to incorrect tagging.
  • Refactored Folia Environment Detection: Created a dedicated FoliaChecker utility class to centralize and cache the detection of the Folia environment. This improves code organization and avoids redundant reflection calls, with the cache being cleared upon plugin disable.
  • Build Configuration Update: Added a Folia-specific runPaper task to the build.gradle.kts file, targeting Minecraft version 1.21.11 and including the PacketEvents dependency, facilitating Folia development and testing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Folia compatibility by refactoring environment detection into a dedicated FoliaChecker utility class. It also adds a new configuration option to prevent self-tagging on Folia servers and updates the build configuration to support Folia. The changes are well-structured and address the reported issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants