fix(validate): Use GITHUB_BASE_REF when set so CI validates against PR base#34
Merged
EspenAlbert merged 4 commits intomainfrom Mar 11, 2026
Merged
fix(validate): Use GITHUB_BASE_REF when set so CI validates against PR base#34EspenAlbert merged 4 commits intomainfrom
EspenAlbert merged 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 65.55% 68.58% +3.03%
==========================================
Files 24 24
Lines 1344 1372 +28
==========================================
+ Hits 881 941 +60
+ Misses 463 431 -32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated `path-sync validate-no-changes` command to accept branch names from the environment variable `GITHUB_BASE_REF`. - Modified documentation to clarify branch handling in CI. - Added tests for `validate_no_changes` and `parse_skip_sections` functions to ensure correct behavior. - Improved logging for validation process.
EspenAlbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-no-changesnow uses theGITHUB_BASE_REFenvironment variable when set and-bis not passed. In GitHub Actions this is set to the PR base branch onpull_requestevents, so validation compares the working tree against the correct base (e.g.develop) instead of alwaysmain.Why: PRs that target a non-
mainbranch were incorrectly compared againstmain, causing false failures or missed checks (issue #33).How: The
--branchoption inpath_sync._internal.cmd_validatehasenvvar="GITHUB_BASE_REF". Docs and help text were updated.Reviewer notes: No breaking change. Explicit
-bstill overrides the env. Workflows that setGITHUB_BASE_REF(e.g.${{ github.base_ref || 'main' }}) and runvalidate-no-changeswithout-bnow get correct behavior. When usingGITHUB_BASE_REF, set it to a non-empty branch name.