Improve performance for Lack of Cohesion metric#801
Merged
mcserep merged 1 commit intoEricsson:masterfrom Jul 8, 2025
Merged
Conversation
4676a2e to
e9b78eb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the lackOfCohesion metric calculation to reduce a three-level database query loop into a two-level in-memory filtering, improving overall performance.
- Combine per-method AST node queries into one batched query.
- Collect methods first, build a single
nodeQueryvia OR clauses, fetch all nodes, then filter in memory. - Extend
CohesionCppAstNodeViewwith start/end positions andfilePathfields to support the new query.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/cpp_metrics/parser/src/cppmetricsparser.cpp | Refactored nested queries into a combined query + in-memory filtering |
| plugins/cpp_metrics/model/include/model/cppcohesionmetrics.h | Added AST node position and filePath columns to support filtering |
Comments suppressed due to low confidence (1)
plugins/cpp_metrics/parser/src/cppmetricsparser.cpp:315
- Add or update tests to verify that the refactored two-level loop produces the same cohesion metrics as the previous implementation.
// Record these fields for later use.
e9b78eb to
3447677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor 3 level nested query loop to 2 level.