feat: new parseConfiguration for error feedback#41
Closed
greghuels wants to merge 4 commits intogreg.huels/FFESUPPORT-348/fix-end-date-parsing-2from
Closed
feat: new parseConfiguration for error feedback#41greghuels wants to merge 4 commits intogreg.huels/FFESUPPORT-348/fix-end-date-parsing-2from
greghuels wants to merge 4 commits intogreg.huels/FFESUPPORT-348/fix-end-date-parsing-2from
Conversation
c7f687c to
98d5a0b
Compare
b76d870 to
639de63
Compare
f9149e7 to
caa7519
Compare
This was referenced Dec 2, 2025
Merged
639de63 to
6eace0c
Compare
982deb3 to
0e748da
Compare
6eace0c to
930e0f7
Compare
0e748da to
f4dd0dd
Compare
930e0f7 to
4aac24a
Compare
f4dd0dd to
a487779
Compare
4aac24a to
fb3c196
Compare
a487779 to
ad4b1d8
Compare
Collaborator
Author
|
Closing since this is mostly captured in #40. I'll open a new PR for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked onto #35
Summary
This PR introduces a new
parseConfiguration()convenience function that provides comprehensive error feedback when parsing flag configurations and bandit models. The new API replaces the previousfrom_jsonpattern with explicit error tracking, making it easier to diagnose configuration issues.What Changed
New Public API
Added
parseConfiguration()convenience function with two overloads:Key Features
Breaking Changes
- Old: BanditResponse response = json_object;
- New: BanditResponse response = internal::parseBanditResponse(jsonStr, error);
- Provides error tracking and better diagnostics
- parseConfigResponse() → internal::parseConfigResponse()
- parseBanditResponse() → internal::parseBanditResponse()
- These are now implementation details; use parseConfiguration() instead
Migration Guide
Before:
After: