Skip to content

sync indexes by key and drop by name#1275

Merged
GregJohnStewart merged 5 commits into
Epic-Breakfast-Productions:developmentfrom
axgiri:dev/1274-core-api-drop-indexes
May 30, 2026
Merged

sync indexes by key and drop by name#1275
GregJohnStewart merged 5 commits into
Epic-Breakfast-Productions:developmentfrom
axgiri:dev/1274-core-api-drop-indexes

Conversation

@axgiri
Copy link
Copy Markdown
Member

@axgiri axgiri commented May 24, 2026

Checklist:

  • Tested

issue #1274

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ae080f55-1085-495e-9ee1-dc41044a334d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@axgiri axgiri force-pushed the dev/1274-core-api-drop-indexes branch from 84208a6 to 85ea693 Compare May 24, 2026 18:55
@axgiri axgiri requested a review from GregJohnStewart May 24, 2026 18:58
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 25, 2026
@axgiri
Copy link
Copy Markdown
Member Author

axgiri commented May 25, 2026

to avoid dealing with comparing index options (which can get messy since there are quite a few fields that could differ), decided to just drop existing indexes and recreate them every time. I was also thinking about an even simpler approach, just drop all indexes at once and recreate everything. but i'm a bit worried though, could it affect app startup?

@axgiri axgiri requested a review from GregJohnStewart May 25, 2026 12:37
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 26, 2026
@GregJohnStewart
Copy link
Copy Markdown
Contributor

GregJohnStewart commented May 26, 2026

@axgiri Yeah, for larger datasets I would worry about the compute impact of recreating every time, let's not drop/ recreate every time.

I think I've heard that just calling the createIndex will do nothing for existent indexes that are the same, but throw an exception for indexes that exist but are different. Would need to test to verify, but would be an easy way to know when to drop/ recreate in the exception handler there

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
@GregJohnStewart GregJohnStewart merged commit 2eb9d6f into Epic-Breakfast-Productions:development May 30, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants