fix(engine-image): add curl for Shell scheduler tasks (Closes #12)#14
Merged
Conversation
Shell nodes commonly call HTTP APIs via curl (webhooks, pipeline executor endpoints, ad-hoc smoke tests). Without it, every shell flow that touches HTTP needs to either install curl at runtime or fall back to wget — neither is a good first impression. curl adds ~1.4 MiB to the image (alpine package), which is below the noise threshold of the existing Python + Node + Docker CLI runtime bundle (~80 MiB combined).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curlto the engine container's Alpine package list.curl: not foundis the first error every new user hits when porting an existing shell script.Size impact
~1.4 MiB on top of the existing image (negligible vs. the ~80 MiB Python + Node + Docker CLI runtime bundle that's already in there).
Closes
Closes #12
Test plan
docker run --rm avalantglobal/runloop-engine:test curl --versionreturns curl 8.x