Skip to content

fix: change default collation allowance#170

Open
Climax777 wants to merge 1 commit into
EnterpriseDB:masterfrom
Climax777:fix/collation
Open

fix: change default collation allowance#170
Climax777 wants to merge 1 commit into
EnterpriseDB:masterfrom
Climax777:fix/collation

Conversation

@Climax777

@Climax777 Climax777 commented Nov 13, 2023

Copy link
Copy Markdown

Make provision for C_COLLATION_OID and POSIX_COLLATION_OID, which are also built-in types.

I'm not 100% sure what the impact will be, but everywhere specifically DEFAULT_COLLATION_OID was used, the other two are allowed now as well.

This fixes #169 and pushes down ObjectID queries for all columns.

Make provision for C_COLLATION_OID and POSIX_COLLATION_OID which are also built-in types.
@vaibhavdalvi93

Copy link
Copy Markdown

@Climax777 , Thanks for the patches. At a glance, changes looks good to me. However, I will have a deeper look into it.

@Climax777

Copy link
Copy Markdown
Author

I found out that $in and $expr cannot make use of indexes. Only equality tests.

I will work in a bigger patch for normal top level $match requests to be flattened and just use normal query style formatting.

Should I rather make a new pull request to keep things simple and clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No WHERE pushdown for ObjectID (NAME) based queries.

2 participants