macOS: detect the installed pgAdmin 4 version and offer install/upgrade/skip#611
Open
agarwal-kritika wants to merge 7 commits into
Open
macOS: detect the installed pgAdmin 4 version and offer install/upgrade/skip#611agarwal-kritika wants to merge 7 commits into
agarwal-kritika wants to merge 7 commits into
Conversation
agarwal-kritika
commented
Jun 9, 2026
agarwal-kritika
commented
Contributor
- read installed version from the app's Info.plist (/Applications, then /Library/PostgreSQL/*)
- compare against the FTP latest; install / upgrade / skip, warn if latest unknown
…mmands - installer.xml.in: when the latest pgAdmin version can't be determined (FTP unreachable), show an interactive warning telling the user to install pgAdmin manually, in addition to logging and skipping. Gated to non-unattended. - install-pgadmin.sh: the case statement now runs the full install flow only when called with NO arguments, and errors out on any unknown command instead of silently downloading and installing pgAdmin (e.g. a typo like "latest version" no longer triggers an install). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
macos-pgadmin-version-detection.patch is a throwaway diff artifact and should not be tracked in the repo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When run from the installer's environment, curl's HTTP/2 stack fails with "curl: (16) Error in the HTTP2 framing layer", even though the same call works from a normal shell - so the latest-version lookup returned empty and pgAdmin was always skipped. Force HTTP/1.1 (which sidesteps the failing framing layer) and add --retry for transient blips, on both the version lookup and the DMG download. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.