Added setting to control the path of elm-format#162
Added setting to control the path of elm-format#162adiron wants to merge 1 commit intoElmCast:masterfrom
elm-format#162Conversation
Some distributions of `elm-format` (e.g. Homebrew on Mac) give the executable(s) names such as `elm-format-0.19`. Previously, the plugin would try to run `elm-format` or else fail. Now, I have added `g:elm_format_command` which can be set to any command/path/etc. so `elm-format` can run even if installed under a weird path.
|
I wonder if this and #162 could be merged together? We could also add the option to allow extra args, such as |
|
Hey. Not sure which PR you're referring to, since this is #162 :P But either way I can try my best, though my viml is very basic |
|
Haha, sorry, #146. |
|
From the looks of it, that PR deals with basically the same thing this one deals with, so I'm fine with closing mine |
|
I haven't had a proper look through the code, so I'm not sure which is a better implementation (though both are quite similar). @otaconix what do you think? |
|
The fact our two diffs are so alike gives me confidence that the approach I took is probably the right one. I'd be absolutely fine with this PR being chosen over mine. Literally the only thing of note among the differences there are, is the name of the variable: |
|
Honestly it's up to you guys, maybe just flip a coin. 😂 #146 is older at least and has just slightly better comments. |
3 participants
Some distributions of
elm-format(e.g. Homebrew on Mac) give theexecutable(s) names such as
elm-format-0.19. Previously, the pluginwould try to run
elm-formator else fail. Now, I have addedg:elm_format_commandwhich can be set to any command/path/etc. soelm-formatcan run even if installed under a weird path.