docs(README): fix key mapping#124
Open
locphan87 wants to merge 1 commit intoElmCast:masterfrom
locphan87:docs/mappings
Open
docs(README): fix key mapping#124locphan87 wants to merge 1 commit intoElmCast:masterfrom locphan87:docs/mappings
locphan87 wants to merge 1 commit intoElmCast:masterfrom
locphan87:docs/mappings
Conversation
* change Leader to LocalLeader based on the implementation
|
This is helpful! I was confused at first about why the mappings weren't working, until I realized they weren't actually using my |
|
Info is misleading, I had to look into source to find out it's not using leader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In
README.md, it is mentioned usingLeaderfor key mappings.But the plugin has been implemented by using
LocalLeader. So the mapping won't work if we follow the documentation (README.md)ref. https://github.com/ElmCast/elm-vim/blob/master/ftplugin/elm.vim#L54
How does this PR solve it?
change Leader to LocalLeader in
README.md