Skip to content

fix: change z-index of text in unitframes #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EllesmereGaming merged 2 commits into from
Mar 12, 2026
Merged

fix: change z-index of text in unitframes #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a24ba
fix: change z-index of text in unitframes
JensBaumannDev Mar 11, 2026
1a63acb
fix: change z-index of text in unitframes and in eui overlay preview
JensBaumannDev Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions EllesmereUIUnitFrames/EUI_UnitFrames_Options.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,10 +929,11 @@ initFrame:SetScript("OnEvent", function(self)
pf._healthFill = healthFill
pf._hR, pf._hG, pf._hB, pf._hA = hR, hG, hB, hA

-- Text overlay frame (sits above absorb StatusBar)
local textOverlay = CreateFrame("Frame", nil, health)
-- Text overlay frame (sits above absorb StatusBar and border)
local textOverlay = CreateFrame("Frame", nil, pf)
textOverlay:SetAllPoints(health)
textOverlay:SetFrameLevel(health:GetFrameLevel() + 3)
textOverlay:SetFrameStrata(pf:GetFrameStrata())
textOverlay:SetFrameLevel(math.max(pf:GetFrameLevel() + 20, health:GetFrameLevel() + 12))

-- Left text
local leftContent = settings.leftTextContent or "name"
Expand Down
5 changes: 3 additions & 2 deletions EllesmereUIUnitFrames/EllesmereUIUnitFrames.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2784,9 +2784,10 @@ local function StyleFullFrame(frame, unit)
UpdateBordersForScale(frame, unit)

-- Text overlay frame -- sits above the StatusBar for clean text rendering.
local textOverlay = CreateFrame("Frame", nil, frame.Health)
local textOverlay = CreateFrame("Frame", nil, frame)
textOverlay:SetAllPoints(frame.Health)
textOverlay:SetFrameLevel(frame.Health:GetFrameLevel() + 12)
textOverlay:SetFrameStrata(frame:GetFrameStrata())
textOverlay:SetFrameLevel(math.max(frame:GetFrameLevel() + 20, frame.Health:GetFrameLevel() + 12))
frame._textOverlay = textOverlay

local leftContent = settings.leftTextContent or "name"
Expand Down