Skip to content

🧪 [Testing] Add coverage for zaman::tkvm_h_v_d function#2

Open
gitmuhammedalbayrak wants to merge 2 commits into
masterfrom
add-zaman-tests-7569442101846725010
Open

🧪 [Testing] Add coverage for zaman::tkvm_h_v_d function#2
gitmuhammedalbayrak wants to merge 2 commits into
masterfrom
add-zaman-tests-7569442101846725010

Conversation

@gitmuhammedalbayrak
Copy link
Copy Markdown
Member

🎯 What: The zaman::tkvm_h_v_d function, which initializes class attributes based on current system time, was previously untested.
📊 Coverage: Added a test in tests/test_zaman.cpp that calls tkvm_h_v_d() and asserts the computed year, month, and day values accurately match values computed by standard localtime using cassert.
Result: Improved overall test coverage and guarantees no regressions when refactoring time parsing in Vasati. Case sensitivity issues for file headers (e.g. Zaman.cpp vs zaman.cpp) were also fixed to ensure reliable testing.


PR created automatically by Jules for task 7569442101846725010 started by @gitmuhammedalbayrak

Co-authored-by: gitmuhammedalbayrak <44205174+gitmuhammedalbayrak@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gitmuhammedalbayrak
Copy link
Copy Markdown
Member Author

@google-labs-jules bu çakışmayı giderebilir misin?

"
This branch has conflicts that must be resolved

Use the command line to resolve conflicts before continuing.

Makefile
src/src-class/Zaman.cpp

"

@google-labs-jules
Copy link
Copy Markdown
Contributor

@google-labs-jules bu çakışmayı giderebilir misin?

"
This branch has conflicts that must be resolved

Use the command line to resolve conflicts before continuing.

Makefile
src/src-class/Zaman.cpp

"

Çakışmaları Makefile ve src/src-class/Zaman.cpp dosyaları için çözdüm ve origin/master dalındaki güncel değişikliklerle (örneğin lib/ dizinini oluşturan init target'ı ve .gitignore eklemeleri) birleştirdim. Ayrıca testlerin çalışması için gerekli dosya adı duyarlılığı düzeltmelerini (Zaman.hpp -> zaman.hpp) de kodun içinde güncelledim.

Co-authored-by: gitmuhammedalbayrak <44205174+gitmuhammedalbayrak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant