fix(cpn): logical switch global variable compare range

[elecpower]

Partially Fixes #7005 and some housekeeping

Applies to 2.11, 2.12 and 3.0

[pfeerick]

If it doesn't make it more confusing, you can use a ternary operator to remove the need for flags... ie.

Suggested change

	bool mod = false;
	if (value < range.min) {
	value = round((range.min - range.offset) / range.step);
	mod = true;
	} else if (value > range.max) {
	value = round((range.max - range.offset) / range.step);
	mod = true;
	}
	if (mod) {
	model->logicalSw[i].val2 = value;
	emit modified();
	}
	if (value < range.min || value > range.max) {
	value = (value < range.min)
	? round((range.min - range.offset) / range.step)
	: round((range.max - range.offset) / range.step);
	model->logicalSw[i].val2 = value;
	emit modified();
	}

Just a suggestion, whatever works best ;) There is also a std::clamp that came in in C++ '17, but lets not go there just yet. 🤭

[philmoz]

I don't think this will work correctly for the ABS and DELTA logical switch functions.

For ABS allowable range must always be positive.
For DELTA allowable range should be between (min - max) and (max - min).
For ABS DELTA allowable range should be between 0 and (max - min).

[elecpower]

I don't think this will work correctly for the ABS and DELTA logical switch functions.

For ABS allowable range must always be positive. For DELTA allowable range should be between (min - max) and (max - min). For ABS DELTA allowable range should be between 0 and (max - min).

Yes and UI widget minimum and maximum also need fixing for these functions too

[elecpower]

I'm still testing the latest commit and trying to fix the lack of value acceleration.

[elecpower]

Testing complete subject to someone finding me out. Tried many approaches and asked Google but to date unable to solve the lack of value Acceleration.