Unify password and PIN login into a single login scene

[j0ntz]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

Merges the two separate login scenes (PasswordLoginScene and PinLoginScene) into a single unified LoginScene that switches between a password flavor and a PIN/biometric flavor in place, per the redesign proposals.

Asana: https://app.asana.com/0/1215088146871429/1215939017452141

What changed:

• New unified LoginScene replaces both old scenes. The passwordLogin and pinLogin routes collapse into one login route, and all internal callsites (initial-route logic, landing, OTP error, recovery, change-PIN, new-account) are rewired to it. The LoginScreen public API and initialRoute values stay backward compatible, so no edge-react-gui change is required.
• Layout uses Option A ordering: the logo sits above the pill toggle, and the toggle copy is "Password" | "Pin/Biometric".
• The username row is a dropdown box when multiple accounts exist (both flavors) and a plain, non-tappable label when only one account is on the device.
• Selecting an account without PIN enabled while on the PIN flavor auto-switches to the password flavor with that account selected and shows the toast "PIN login is not enabled for this account, enter your password". On the password flavor, the Pin/Biometric pill is greyed out when the selected account has no PIN, and tapping it shows the same toast.
• The QR-code button and the forgot-password link are folded into an Option C "Trouble Signing in?" help sheet that offers QR-code login and password recovery via recovery token.

Testing:

Built edge-react-gui with this branch linked via updot and drove the login UI on the iOS simulator (YOLO auto-login disabled so the scene renders):

• PIN flavor renders with the toggle, username dropdown, 4-digit display and keypad; entering the edge-funds PIN logs in to the home screen.
• Tapping the Password pill switches to the password flavor (username dropdown, password field, Login / Create account).
• The "Trouble Signing in?" link opens the Login Help sheet with the QR-code and recovery-token options.

Proof screenshots attached below.

---

Note

Medium Risk
Large refactor of the primary login surface (password, PIN, biometrics, recovery, QR) with new in-scene state; core login APIs are reused but navigation and UX paths changed widely enough to warrant thorough regression testing.

Overview
Replaces PasswordLoginScene and PinLoginScene with one login route and a new LoginScene that switches between password and PIN/biometric flows in place via LoginFlavorToggle, instead of navigating between separate screens.

Routing and entry: LoginInitActions, landing, OTP error, recovery, new-account PIN back, and related paths now navigate to login with loginId, username, and optional passwordOnly (for forced password entry). The router drops the old scene cases; LoginParamList is updated accordingly.

Unified UX: In-scene account picking uses an animated username dropdown (password and multi-account PIN). PIN-capable vs password-only accounts drive auto flavor selection, greyed PIN tab, and toasts when PIN is unavailable. Forgot-password and QR login move from inline controls to LoginHelpModal behind "Trouble Signing in?"

Theming: Dark theme adds loginToggleBackground / loginToggleSelected and adjusts filled text-input colors to align with edge-react-gui.

^{Reviewed by Cursor Bugbot for commit 7cfe75b. Bugbot is set up for automated code reviews on this repo. Configure here.}

[j0ntz]

📸 Test evidence (iOS sim)

agent proof 1215939017452141 01 login pin flavor

agent proof 1215939017452141 02 login password flavor

agent proof 1215939017452141 03 login help modal

agent proof 1215939017452141 04 login success home

Captured by the agent's in-app test run (build-and-test).

[j0ntz]

📸 Test evidence — design feedback (grey toggle, grey FilledTextInput inputs, no blue)

agent proof 1215939017452141 01 login pin flavor

agent proof 1215939017452141 02 login password flavor

agent proof 1215939017452141 03 login success home

Captured by the agent's in-app test run (build-and-test).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5713096. Configure here.}

[j0ntz]

📸 Test evidence: 1rem logo gap fix + PIN login (this followup)

logo gap before too tight

logo gap after 1rem

pin login success home

Captured by the agent's in-app test run (build-and-test).