Convert yarn → npm + Socket security upgrades + @edge.app fork aliases#454
Open
peachbits wants to merge 2 commits into
Open
Convert yarn → npm + Socket security upgrades + @edge.app fork aliases#454peachbits wants to merge 2 commits into
peachbits wants to merge 2 commits into
Conversation
added 2 commits
May 26, 2026 14:10
Adds `overrides` so transitive `ecpair`, `bs58grscheck@^2`, and `groestl-hash-js` resolve through the @edge.app registry packages instead of git URLs. EEP itself doesn't directly depend on any of these — they come in via `edge-currency-plugins` and `edge-currency-accountbased` (both devDeps). With these overrides, the install graph no longer contains git URLs for those three packages. Remaining git dep `@fioprotocol/fiosdk` (via ECA) is outside this PR's scope and will be replaced with the registry-published `@fioprotocol/fiosdk@^1.10.3` separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three-commit branch:
ecpair,bs58grscheck@^2, andgroestl-hash-js(all pulled in transitively viaedge-currency-pluginsandedge-currency-accountbased) now resolve through the registry instead of git URLs.Avoids the npm git-dep-prep bug (npm/cli#9005) that conflicts with
min-release-agein user~/.npmrc.Remaining work outside this PR
@fioprotocol/fiosdkis still pulled in via a git URL throughedge-currency-accountbased. That will be addressed by switching ECA's direct dep to the registry-published@fioprotocol/fiosdk@^1.10.3(upstream now ships types itself, making the EdgeApp fork obsolete).Test plan
sfw npm installsucceeds (after ECA's fiosdk move and 7-day age-in for the new @edge.app packages, or vianpm ci)@fioprotocol/fiosdk(verified locally)Note
Medium Risk
Medium risk from dependency resolution/overrides and lockfile churn affecting installs and transitive crypto libs; runtime plugin logic in the diff is mostly documentation and tooling.
Overview
This PR moves the repo from Yarn to npm as the package manager:
.yarnrcis removed,.npmrcaddslegacy-peer-depsandignore-scripts, and.gitignoreno longer excludespackage-lock.jsonso the npm lockfile is tracked. Docs and scripts (README, exchange-plugin guides,convert.sh) now usenpm install/npm runinstead ofyarn.Per the PR scope (see
package.json), it also applies Socket-recommended dependency upgrades andoverridesso transitive git deps resolve to@edge.app/*registry aliases (ecpair,bs58grscheck,groestl-hash-js) plus@fioprotocol/fiosdkon the registry—reducing install friction with strict npm registry policies.Note: Some in-repo references may still say
yarn(e.g. CI/mapctlstrings); the diff shown updates the main contributor-facing docs.Reviewed by Cursor Bugbot for commit af93a63. Bugbot is set up for automated code reviews on this repo. Configure here.