Add wallet settings

[peachbits]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

Note

Medium Risk
Touches wallet creation timing, synced storage, and the currency engine contract; behavior is opt-in via hasWalletSettings but incorrect plugin handling could affect wallet startup or settings sync.

Overview
Adds per-wallet settings (walletSettings) that live on the synced wallet repo in WalletSettings.json, separate from account-level userSettings.

EdgeCurrencyWallet exposes walletSettings and changeWalletSettings (gated by EdgeCurrencyInfo.hasWalletSettings). Creation paths accept optional walletSettings in EdgeCreateCurrencyWalletOptions; the core prewrites them to disk before applyKit so the wallet pixie loads the right values when the engine starts. Redux tracks settings, reloads them on sync when the file changes, and the wallet watcher calls optional engine.changeWalletSettings. EdgeCurrencyEngine construction now receives walletSettings; memory wallets pass them through as well.

Also exposes imported on EdgeCurrencyWallet, and wallet split restore always calls changeWalletStates when there are wallets to un-archive (drops the previous “only if archived/deleted” short-circuit).

^{Reviewed by Cursor Bugbot for commit f87eace. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

🔒 Agentic Security Review
Severity: MEDIUM
Raw walletSettings are logged via JSON.stringify(walletSettings). Because these settings are plugin-defined, they may include secrets or tokens, and this log line can expose sensitive values to log sinks.

Impact: Sensitive wallet configuration data could be disclosed through logs and any downstream log aggregation.

[cursor]

CHANGELOG omits new imported public API property

Low Severity

The PR adds a new public imported property on EdgeCurrencyWallet (in both types.ts and currency-wallet-api.ts), but the CHANGELOG entry only covers walletSettings and changeWalletSettings. Since imported is a newly exposed API on EdgeCurrencyWallet, it warrants its own added: entry in the CHANGELOG.

Additional Locations (2)

• src/types/types.ts#L1334-L1335
• src/core/currency/wallet/currency-wallet-api.ts#L139-L142

 

^{Triggered by learned rule: CHANGELOG entries must use correct semantic prefix}

^{Reviewed by Cursor Bugbot for commit f87eace. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f87eace. Configure here.}

[cursor]

Debug wallet settings warn logs

Low Severity

The wallet-settings watcher logs every apply and error at warn with JSON.stringify of settings. That looks like temporary instrumentation, adds noisy production logs, and may write wallet configuration into crash or log pipelines.

 

^{Reviewed by Cursor Bugbot for commit f87eace. Configure here.}