Conversation
67bb27b to
13f677b
Compare
|
This is great! Can we just add to the readme this requirement so people are aware that envpool only works with jax less than 0.6.0. This unfortunately means all the sebulba architecture algorithm cannot be updated beyond this version of jax. I think unfortunately we are going to start getting into these issues where keeping up with jax versions becomes tough due to environment maintainers stopping to ensure their envs work with up to date jax versions. It might be worth starting to think about how to maintain this. Potentially we can just do it with release tags of stoix. |
refactor: move envpool with jax constraint to optional dependency group chore: update README for envpool installation chore: make README spelling of "optimise" consistent
|
Maybe the best way to ensure this is to move the envpool dependency into an extra in [project.optional-dependencies]
envpool = [
"envpool>=0.8.4 ; sys_platform == 'linux'",
"jax>=0.4.25,<0.6.0",
]Then inside the main |
What?
Right now running with Jax 0.6.0 causes any script to fail (see #157). This change makes it so that it only fails for the relevant envpool environments and other environments can run properly.
Why?
Preparing for a more significant fix later on to allow updated Jax versions.
How?
In
make_env.py, we just put theEnvFactoryimport insideif TYPE_CHECKINGsince it's only used to annotate the return type ofEnvFactory. We move theJaxEnvFactoryinside the relevant branch as well.