Update sr-only text for engineering ethics section#25
Conversation
📝 WalkthroughWalkthroughThe hero section's screen-reader-only text in ChangesHero section accessibility text
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/App.vue (1)
70-70: ⚡ Quick winAlign hero sr-only copy with global metadata/title messaging.
Line 70 now uses a different phrase than the visible hero title (Line 68) and existing app-level metadata (
index.html,public/manifest.webmanifest). If this is a deliberate rebrand, update those surfaces too; otherwise keep wording consistent to avoid mixed messaging for users and assistive tech.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/App.vue` at line 70, The hidden accessibility text ("確かな技術は、誠実な倫理から生まれる。") in App.vue does not match the visible hero title and the app-level metadata; either update the sr-only copy to exactly match the visible hero string used in the hero component (the visible title at the hero element around Line 68) or, if the new phrasing is intentional, update the global metadata/title in index.html and public/manifest.webmanifest to the new phrase so all user-facing and assistive-tech strings (the sr-only paragraph in App.vue and the site title/manifest) remain consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/App.vue`:
- Line 70: The hidden accessibility text ("確かな技術は、誠実な倫理から生まれる。") in App.vue does
not match the visible hero title and the app-level metadata; either update the
sr-only copy to exactly match the visible hero string used in the hero component
(the visible title at the hero element around Line 68) or, if the new phrasing
is intentional, update the global metadata/title in index.html and
public/manifest.webmanifest to the new phrase so all user-facing and
assistive-tech strings (the sr-only paragraph in App.vue and the site
title/manifest) remain consistent.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| <h1 class="title">技術者倫理を守ろう</h1> | ||
|
|
||
| <p class="sr-only">技術者倫理を守ろう。</p> | ||
| <p class="sr-only">確かな技術は、誠実な倫理から生まれる。</p> |
There was a problem hiding this comment.
| <p class="sr-only">確かな技術は、誠実な倫理から生まれる。</p> | |
| <p class="sr-only">技術者倫理を守ろう</p> |
sr-only見えてるの絶対バグだから直してほしいぴょん
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
|
To use Codex here, create an environment for this repo. |
2 participants
This PR updates sr-only text
Summary by CodeRabbit
Summary by cubic
Updated the
sr-onlytext in the Engineering Ethics hero to improve clarity for screen readers. New message: "確かな技術は、誠実な倫理から生まれる。"Written for commit aea1c8a. Summary will update on new commits.