STD-68 | Organization feature: adjust domain and persistence layer#52
Draft
WerewolfNet wants to merge 2 commits into
Draft
STD-68 | Organization feature: adjust domain and persistence layer#52WerewolfNet wants to merge 2 commits into
WerewolfNet wants to merge 2 commits into
Conversation
SleepyF0X
reviewed
Oct 18, 2021
| public int OwnerId { get; set; } | ||
| public OrganizationStatus Status { get; set; } | ||
| public DateTimeOffset DateCreated { get; private set; } | ||
| void IWithDateCreated.SetDateCreated(DateTimeOffset value) => DateCreated = value; |
Member
There was a problem hiding this comment.
Please, move this property to the last line
|
|
||
| namespace StudySharp.Domain.Models | ||
| { | ||
| public sealed class Organization : IWithDateCreated |
| @@ -0,0 +1,9 @@ | |||
| namespace StudySharp.Domain.Models | |||
| { | |||
| public enum AppearanceType | |||
Member
There was a problem hiding this comment.
Are you sure we won't have access modifiers for other entities in the future?
Maybe add "Course" to this name, or change it to more corresponding to courses
| @@ -4,10 +4,7 @@ namespace StudySharp.Domain.Models | |||
| { | |||
| public sealed class Teacher | |||
| { | |||
Member
There was a problem hiding this comment.
Please, add DomainUser to Teacher, it may help us in some situations
| { | ||
| public void Configure(EntityTypeBuilder<Organization> builder) | ||
| { | ||
| throw new NotImplementedException(); |
| { | ||
| public void Configure(EntityTypeBuilder<OrganizationRepresentative> builder) | ||
| { | ||
| throw new NotImplementedException(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.