Skip to content

When doing section-analysis, recurse in types body #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strub merged 1 commit into from
Jan 13, 2026
+13 −3
Merged

When doing section-analysis, recurse in types body #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/ecSection.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,13 @@ type aenv = {
}

and acache = {
op : Sp.t; (* Operator declaration already handled *)
op : Sp.t; (* Operator declaration already handled *)
type_ : Sp.t; (* Type declaration already handled *)
}

(* -------------------------------------------------------------------- *)
let empty_acache : acache =
{ op = Sp.empty; }
{ op = Sp.empty; type_ = Sp.empty; }

(* -------------------------------------------------------------------- *)
let mkaenv (env : EcEnv.env) (cb : cb) : aenv =
Expand Down Expand Up @@ -154,9 +155,18 @@ and on_ty (aenv : aenv) (ty : ty) =
| Tvar _ -> ()
| Tglob _ -> ()
| Ttuple tys -> List.iter (on_ty aenv) tys
| Tconstr (p, tys) -> aenv.cb (`Type p); List.iter (on_ty aenv) tys
| Tconstr (p, tys) -> on_tyname aenv p; List.iter (on_ty aenv) tys
| Tfun (ty1, ty2) -> List.iter (on_ty aenv) [ty1; ty2]

(* -------------------------------------------------------------------- *)
and on_tyname (aenv : aenv) (p : path) =
aenv.cb (`Type p);
if not (Sp.mem p !(aenv.cache).type_) then begin
let cache = { !(aenv.cache) with type_ = Sp.add p !(aenv.cache).type_ } in
aenv.cache := cache;
on_tydecl aenv (EcEnv.Ty.by_path p aenv.env)
end

(* -------------------------------------------------------------------- *)
and on_opname (aenv : aenv) (p : EcPath.path) =
aenv.cb (`Op p);
Expand Down