metadata v2 v3#17
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors metadata handling in src/serve_zarr.jl by replacing _synthetic_zmetadata with helper functions _has_consolidated_metadata and _generate_metadata. However, the review identified three key issues: a critical bug where removing the path check causes the server to return synthetic metadata for any missing file instead of a 404; an inefficiency where Zarr v3 stores trigger unnecessary and expensive metadata generation; and the removal of a guard check that allows arbitrary non-Zarr directories to attempt consolidation. Please address these issues by restoring the path and store-type checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
\gemini review |
we let zarrita handle the metadata requests if is available on disk. And for v2, we generate some if not available. For v3, ideally it should also be handle in zarr.jl, see JuliaIO/Zarr.jl#287