Skip to content

support http 1 and 2#16

Merged
lazarusA merged 8 commits into
mainfrom
la/migrate_http_v2
Jun 4, 2026
Merged

support http 1 and 2#16
lazarusA merged 8 commits into
mainfrom
la/migrate_http_v2

Conversation

@lazarusA

@lazarusA lazarusA commented Jun 4, 2026

Copy link
Copy Markdown
Member

closes #11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces compatibility abstractions to support both HTTP 1.x and 2.x, defines a new ZarrServer struct with associated management functions, and updates the browzarr entry point and tests accordingly. The review feedback highlights three critical issues: a potential MethodError in start_browzarr when port is nothing, an inefficient file-reading mechanism in serve_zarr that could lead to out-of-memory errors on large Zarr chunks, and an unnecessary memory read of existing .zmetadata files that triggers misleading logs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/servers.jl Outdated
Comment thread src/serve_zarr.jl
Comment thread src/serve_zarr.jl
@lazarusA lazarusA merged commit 8415d03 into main Jun 4, 2026
9 checks passed
@lazarusA lazarusA deleted the la/migrate_http_v2 branch June 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

functions to get zarr's ports servers and close them all

1 participant