Skeleton loading states for async card grids#1614
Merged
RUKAYAT-CODER merged 22 commits intoJun 1, 2026
Merged
Conversation
|
@dot-enny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow. |
…inds config on Windows
…skeleton-loading-states-for-async-card-grids # Conflicts: # FrontEnd/my-app/components/quest/DeadlineTimer.tsx # FrontEnd/my-app/lib/hooks/useApi.ts
92845a4 to
33d16c7
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #881
Description
What changed?
animate-pulsefallback boxes in async data views with structuredSkeletoncomponents from the UI library (@/components/ui/Skeleton)./quests) and Submission (/submissions) pages to utilizeSkeleton.CardandSkeleton.Listrespectively for theirSuspensefallbacks./quests/[id]) to correctly apply a structuredSkeleton.TextandSkeleton.Cardlayout for loading states instead of plain generic boxes.next.config.tsrelated to a duplicate declaration that originated from a recent merge.Why was it changed?
To address issue #881 by providing consistent, branded, and visually appealing skeleton loading states across all async card grids, improving perceived performance and the overall user experience during API fetches.
How was it implemented?
I imported the pre-existing
<Skeleton />compound components from our UI library and swapped them into thefallbackprops ofSuspenseboundaries in Next.js page components where hard-codedanimate-pulsedivs were originally used.Type of Change
Test Evidence
Unit Tests
npm run test)npm run test:cov)Test output / screenshot:
E2E / Integration Tests
npm run test:e2e)Endpoints tested:
GET/api/…Swagger / API Documentation
@ApiOperation,@ApiResponse, and@ApiBearerAuthdecorators@ApiProperty/@ApiPropertyOptional/api/docsand responses are accurateError Handling Checklist
HTTP Exceptions
NotFoundException,BadRequestException,ForbiddenException,UnauthorizedException,ConflictException, etc.)Errorthrown where an HTTP exception is expectedInput Validation (DTOs)
class-validatordecorators (@IsString,@IsUUID,@IsNotEmpty,@IsOptional, etc.)class-transformerdecorators applied where necessary (@Transform,@Type,@Expose)ValidationPipeis applied globally or at the controller level — raw unvalidated input is never usedGuards & Authorization
@UseGuards(JwtAuthGuard)or equivalent@Public()decorator where applicableLogging
LoggerService)errorlevel with stack tracesLoggerMiddleware— no duplicate logs addedStellar / Soroban Contract Interactions
Database / Migration
npm run typeorm:generate-migration)seed.ts)Final Pre-Merge Checklist
main/masternpm run lint)npm run format)console.log/ debug statements left in production code.env.exampleupdated if new environment variables were introducedReadMe Backend.mdorReadMe Frontend.mdupdated if setup steps changedScreenshots / Recordings (if applicable)
Additional Notes for Reviewer
(Also resolved a minor configuration syntax error in
next.config.tsintroduced by previous merges.)