Merged
Conversation
Michael-EY
force-pushed
the
livesey/allow-two-PIs
branch
from
07b2ab2 to
4ed3bec
Compare
Michael-EY
force-pushed
the
livesey/allow-two-PIs
branch
from
4ed3bec to
d24321a
Compare
jiajieey
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes our recursive proving system so that each layer (except the decider circuit) now has 2 public inputs (instead of 1). This is so we can encode the full hash of the "would-be public inputs" instead of just the top 31 bytes, which sacrifices some bits of security. This PR prepares
nightfall_4_PVfor "Issue Q [Client]".This PR now passes a full
nightfall_4_PVtest on the server.