Apply fix for count of group by query#13
Conversation
|
Looking at the Linux job on Travis, we see that this generates a new error when running the tests: |
|
@OskarPersson Any idea what in this would impact FK constraints? Admittedly, it's a bit beyond my internal knowledge of MSSQL/DB backends, but I don't mind plugging away if I have a general direction. On a working level, the patch seems to address a few issues and I haven't had any issue with M2M fields in my tests (although clearly there are issues somewhere). |
|
I have now tried to run this locally and it seems that test_alter_field_m2m is just a "flaky" test with this library, will have to look into that separately, i.e. we can ignore this error here. Though I would prefer to see some change in the test results before merging this, ensuring that this works as it should. |
This addresses the issues I raised in #12 and is simply reapply a fix proposed upstream at nattster@b095b20 and michiya@761a3a8 that didn't seem to make it into this fork.