Skip to content

ci: simplify test workflow — matrix go tests, un-gate build#410

Merged
SantiagoDePolonia merged 1 commit into
ci/supply-chain-vulncheckfrom
ci/simplify-test-workflow
Jun 17, 2026
Merged

ci: simplify test workflow — matrix go tests, un-gate build#410
SantiagoDePolonia merged 1 commit into
ci/supply-chain-vulncheckfrom
ci/simplify-test-workflow

Conversation

@SantiagoDePolonia

@SantiagoDePolonia SantiagoDePolonia commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Stacked on #409 (base branch ci/supply-chain-vulncheck). Review/merge that first; this PR's diff then collapses to just the workflow simplification once rebased onto main.

Summary

Two no-coverage-change simplifications to test.yml:

  1. Collapse the four Go test jobs into one matrix. Unit Tests, E2E Tests, Integration Tests, and Contract Replay Tests shared identical checkout + setup-go + cache boilerplate and differed only in the test command. They're now a single go-tests matrix job. Net: −50 / +22 lines, same parallelism, same suites.
  2. Un-gate the build job. It previously declared needs: [lint, test-unit, …, performance], which serialized a fresh-runner recompile to after the slowest test finished. Compiling ./cmd/gomodel doesn't depend on tests passing, so it now runs in parallel — shortening the critical path.

Compatibility

  • Matrix name: ${{ matrix.name }} renders to the exact same check names (Unit Tests, E2E Tests, Integration Tests, Contract Replay Tests), so required-status-check rules in branch protection keep matching with no reconfiguration.
  • Codecov upload now runs only on the Unit Tests matrix row (if: matrix.coverage), same as before.

User-visible impact

None at runtime — CI-only. Faster feedback (build no longer waits on tests) and less workflow boilerplate.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Consolidated Go test execution (unit, E2E, integration, contract replay) into a single matrix job, eliminating duplicate test job configurations.
    • Build job now runs in parallel with test jobs instead of sequentially, improving CI/CD pipeline efficiency.

The unit, e2e, integration, and contract jobs shared identical
checkout/setup-go/cache boilerplate and differed only in the test
command, so they now run as a single matrix job. Check names are
preserved (Unit Tests, E2E Tests, Integration Tests, Contract Replay
Tests) so required status checks keep matching.

The build job no longer waits on the test jobs — compiling the binary
doesn't depend on tests passing, so it now runs in parallel and
shortens the critical path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 255870b8-6ffe-43bd-be16-1955f91f4acd

📥 Commits

Reviewing files that changed from the base of the PR and between 691400b and 7893eb4.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow consolidates four separate Go test jobs (unit, E2E, integration, contract replay) into a single go-tests matrix job with per-entry cmd and coverage fields. The standalone jobs are removed, and the build job's needs dependencies on test jobs are dropped so it runs in parallel.

Changes

CI Workflow Consolidation

Layer / File(s) Summary
go-tests matrix job definition and execution steps
.github/workflows/test.yml
Adds a go-tests matrix with four suite entries each specifying a cmd and optional coverage flag; replaces hardcoded per-suite steps with a single matrix.cmd run step and a coverage upload gated on matrix.coverage; removes the now-redundant standalone test-e2e, integration, and test-contract job definitions.
Build job decoupled from test jobs
.github/workflows/test.yml
Removes the needs list from the build job so it executes in parallel with test jobs rather than waiting for their completion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Hop, hop, the matrix aligns,
Four suites now run on parallel vines,
No more redundant jobs in a row,
The build flies free with nowhere to go!
One workflow file, one tidy design. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the two main changes: consolidating Go tests into a matrix and removing the build job's dependencies to run it in parallel.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/simplify-test-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SantiagoDePolonia SantiagoDePolonia self-assigned this Jun 17, 2026
@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed workflow.
  • The matrix commands are static and preserve the same test commands.
  • No internal workflow dependencies still reference the removed Go test job ids.

Reviews (1): Last reviewed commit: "ci: collapse go test jobs into a matrix ..." | Re-trigger Greptile

@SantiagoDePolonia SantiagoDePolonia merged commit 7893eb4 into ci/supply-chain-vulncheck Jun 17, 2026
3 checks passed
@SantiagoDePolonia SantiagoDePolonia deleted the ci/simplify-test-workflow branch June 17, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant