Skip to content

New logic in told with key datamodel. If already a class: subClassOf#524

Closed
francescalb wants to merge 1 commit intomasterfrom
datmodel_treated_depending_on_type
Closed

New logic in told with key datamodel. If already a class: subClassOf#524
francescalb wants to merge 1 commit intomasterfrom
datmodel_treated_depending_on_type

Conversation

@francescalb
Copy link
Copy Markdown
Contributor

Description

See discussion in #522 . Not both of these PR's should be accepted.
In my opinion, we should remove this logic alltogether (so make another PR).
We cannot assume a priori what the keyword datamodel means for the people providing their documented data.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.98%. Comparing base (d3b4b2f) to head (b51c0de).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          30       30           
  Lines        4967     4970    +3     
=======================================
+ Hits         4221     4224    +3     
  Misses        746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@francescalb
Copy link
Copy Markdown
Contributor Author

Agreed to remove parsing of datamodel like this alltogether.

@francescalb francescalb closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant