Allow build with CMake 4.0.0#1
Open
heitbaum wants to merge 1 commit into
Open
Conversation
use min...max syntax to allow build with newer cmake. ref: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
|
Why don't you just raise the minimum version to at least 3.5 or 3.10? |
Author
If that is the preference - we can (thus dropping support for building with < 3.10) - no issue either way, as the CMakeLists.txt file does not have use any functionality 3.0-3.10. Ideally best to go with a minimum, as then there is no need to support the range. generally there has been a 50/50 direction set with packages I raised PRs on, some went range (they wanted to continue to support old cmake, the others when with 3.10 or greater) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use min...max syntax to allow build with newer cmake.
ref: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html