Skip to content

fix(#444): scope export CSV to session-unique filename in prepareCSV/downloadCSV #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejassinghbhati wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#444): scope export CSV to session-unique filename in prepareCSV/downloadCSV #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions API/Routes/Case/CaseRoute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from flask import Blueprint, jsonify, request, session, send_file
import os
import uuid
from pathlib import Path
import shutil
import pandas as pd
Expand Down Expand Up @@ -432,10 +433,13 @@ def prepareCSV():
Pd.insert(i, p_col, col)
i=i+1

Pd.to_csv(Path(Config.DATA_STORAGE,casename,'export.csv'), index = None)
# Generate a session-scoped unique filename to prevent concurrent
# sessions from overwriting each other's export. Fixes #444.
export_filename = f"export_{uuid.uuid4().hex}.csv"
session['export_file'] = export_filename

Pd.to_csv(Path(Config.DATA_STORAGE, casename, export_filename), index=None)

# Pd.to_excel(Path(Config.DATA_STORAGE,casename,'export.xlsx'))

response = {
"message": 'CSV data downloaded!',
"status_code": "success"
Expand All @@ -451,11 +455,16 @@ def downloadCSV():
casename = session.get('osycase', None)
if casename is None:
return jsonify({'message': 'No active session. Please select a model first.', 'status_code': 'error'}), 400
dataFile = Path(Config.DATA_STORAGE,casename,'export.csv')

dir = Path(Config.DATA_STORAGE,casename)
return send_file(dataFile.resolve(), as_attachment=True,mimetype='application/csv', max_age=0)
#return send_from_directory(dir, 'export.csv', as_attachment=True)

# Read the session-scoped filename written by prepareCSV. Falls back
# to the legacy name so existing workflows are not broken. Fixes #444.
export_filename = session.get('export_file', 'export.csv')
dataFile = Path(Config.DATA_STORAGE, casename, export_filename)

if not dataFile.exists():
return jsonify({'message': 'Export file not found. Please prepare the CSV export first.', 'status_code': 'error'}), 404

return send_file(dataFile.resolve(), as_attachment=True, mimetype='application/csv', max_age=0)
except(IOError):
return jsonify('No existing cases!'), 404

Expand Down
Loading