Dev 1885: sandbox-simulations schemas + GET customer sole prop variant#52
Merged
Conversation
| SandboxSimulationBankProcessingRequest: | ||
| title: SandboxSimulationBankProcessingRequest | ||
| description: | | ||
| Omit the body, send JSON null, or an empty JSON object. Triggers processing (or failure) for the last |
Member
There was a problem hiding this comment.
Haven't tested this but do we accept JSON null?
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging this! Sorry, I missed it in the first pass. We don’t accept JSON null as the body; it returns 400 Bad Request error. I’ve updated the spec so bank processing only allows omitting the body or {} (which is supported), removed the null branch from the schema, and documented 400 with BadRequestError.
spencerhunter
previously approved these changes
Mar 26, 2026
spencerhunter
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Dwolla OpenAPI source so bundled specs and generated clients match real Sandbox and customer payloads.
POST
/sandbox-simulationstype: objectrequest/response with explicit schemas inspecs/schemas/sandbox/SandboxSimulations.ymland wires them fromspecs/resources/sandbox-simulations.yml.GET
/customers/{id}VerifiedSolePropCustomerto the 200oneOfbefore VerifiedBusinessCustomer inspecs/resources/customers/retrieveUpdateCustomer.yml, aligned with list/update customer schemas, so sole proprietorship customers validate instead of being forced through the controller-based business schema.Follow-up: regenerate downstream SDKs from the updated bundle