[DRAFT] Magma + new GL implementation v2#825
Draft
snacchus wants to merge 274 commits intoDragonMinded:previewfrom
Draft
[DRAFT] Magma + new GL implementation v2#825snacchus wants to merge 274 commits intoDragonMinded:previewfrom
snacchus wants to merge 274 commits intoDragonMinded:previewfrom
Conversation
There was an edge case in which it was impossible to insert more items without triggering an assertion. When the hashtable was initialised with capacity 4 and 4 items were inserted, then one item removed, 3 entries were now occupied and the last one contained a tombstone marker. When inserting another item, the loop in hashtable_lookup_slot ended on the tombstone and triggered the assert afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to get an overview of the changes for the following:
Compared to the previous attempt, this implementation supports display lists.