the workplace accident update: salvage demolition charges and recycler vacuum cleaners#1113
Conversation
carda-sometimesknownas-paxilmaniac
requested review from
00-Steven and
desertmote
as code owners
github-actions
Bot
added
Tools
Sprites
00-Steven
left a comment
00-Steven
left a comment
There was a problem hiding this comment.
aside from the question that drew my attention
| righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi' | ||
| w_class = WEIGHT_CLASS_SMALL | ||
|
|
||
| /obj/item/demo_charge_detonator/attack_self(mob/user) |
There was a problem hiding this comment.
might wanna use interact or w/e, just like, whatever makes sure clicking this adds fingerprints
There was a problem hiding this comment.
so yeah does this apply fingerprints currently? cause it should
carda-sometimesknownas-paxilmaniac
requested review from
dawsonkeyes and
kannthus
as code owners
carda-sometimesknownas-paxilmaniac
changed the title
| boom_sizes = list(1, 3, 5) | ||
| directional_arc = 200 | ||
| if(3) | ||
| boom_sizes = list(0, 5, 7) |
There was a problem hiding this comment.
these are absolutely massive explosion sizes - a minibomb grenade is 1 dev / 2 heavy / 4 light for reference
There was a problem hiding this comment.
2/10 or 1/5 being minibombs is probably a bit too much
that said these by default only work properly on da salvage shuttles so more of a shrug
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
3 participants
About The Pull Request
adds demolition charges and matching remote to engineering and supply lathes
plant the demo charge on the wall like c4, has no timer but instead requires the remote in order to explode
click the remote until the charges explode. Usually takes 3 clicks. usually.
also adds effects in front of the salvage inlets on every map that pull items towards the recycler/conveyor belt when they pass through, making resource collection a little easier.
Why It's Good For The Game
Welding as the only option for destroying walls in shipbreaking is lame, we need everyone to be able to nuke themselves into the stone age by accident
Trying to make sure items go into the outlet can be a bit of a hassle as well and the pulling effect in front of the inlets should help this.
Changelog
🆑
add: adds demo charges and matching remotes to engineering and cargo lathes that only work (by default) on shipbreaking shuttles
add: suction effects that pull unanchored things towards the inlets of the recycler and collector in salvage yards
/:cl: