feat(i18n): reimplement Hindi (hi) localization file#485
Merged
Conversation
Reinstates wata-board-frontend/src/i18n/locales/hi.json, which had been
deleted, restoring full Hindi (Devanagari) support for the app.
- Translate all UI strings to Hindi in Devanagari script (app, payment,
wallet, network, offline, about, contact, rate, errors, accessibility,
common, time, currency, validation)
- Handle Hindi pluralization with i18next _plural keys (e.g. घंटा/घंटे,
महीना/महीनेkeeping invariable forms where the language requires
- Use correct number formatting: numerals and {{count}}/{{amount}}
interpolations consistent with the source, formatted at runtime via Intl
- Keep all interpolation placeholders ({{id}}, {{count}}, {{time}}, etc.)
intact and aligned with en.json
Closes DogStark#368
|
@Kalebtron1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reimplements the Hindi localization file
wata-board-frontend/src/i18n/locales/hi.json, which had been deleted. This restores full Hindi (Devanagari script) support for the app — important given Hindi is spoken by 600M+ people, primarily in India, one of the fastest-growing crypto markets.Changes
app,navigation,payment,wallet,network,offline,about,contact,rate,errors,accessibility,common,time,currency, andvalidation._pluralkeys (e.g.घंटा/घंटे,महीना/महीनेkeeping invariable forms where the language requires them (मिनट,दिन,सप्ताह).{{count}}/{{amount}}interpolations matchen.jsonand are formatted atruntime via
Intlbased on the active locale.{{id}},{{count}},{{time}},{{error}},{{network}},{{min}},{{max}}) preserved and aligned key-by-key withen.json.Acceptance criteria
This PR closes #368, but the acceptance criterion "Translations are reviewed by a native speaker" has not yet been fulfilled. The Hindi strings were
produced and self-checked for grammatical/pluralization correctness, but a native Hindi speaker should review them before/after merge. Please flag any
phrasing that should be refined in a follow-up.
Local environment note
The app has pre-existing build/runtime errors unrelated to this PR
that prevent
npm run devfrom running locally. Since this PR onlyadds
hi.json(a static JSON file with no logic), correct renderingdepends entirely on the app's existing i18n setup and font support,
which are outside the scope of this change.
Closes #368