[FEATURE] 디자이너 외주 찾기 목록 조회 기능 추가#59
Conversation
There was a problem hiding this comment.
Pull request overview
디자이너가 모집 중(RECRUITING) 외주 목록을 페이징으로 조회할 수 있는 신규 API(GET /api/v1/designers/commissions)를 추가하고, 디자이너 레벨에 따른 금액 정책을 응답에 포함하도록 구성한 PR입니다.
Changes:
- 디자이너용 모집 중 외주 목록 조회 API 컨트롤러/파사드/서비스/매퍼 및 응답 DTO 추가
CommissionRepository에 상태 기반 페이징 조회 메서드 추가- 디자이너 조회/레벨 정책 관련 에러코드 및 금액 정책(레벨별 기본금 + 최대 보너스) 추가
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/ditda/backend/domain/designer/service/DesignerService.java | 디자이너 엔티티 조회 전용 서비스 추가 |
| src/main/java/ditda/backend/domain/designer/exception/DesignerErrorCode.java | 디자이너 조회 실패/레벨 정책 미존재 에러 코드 추가 |
| src/main/java/ditda/backend/domain/commission/core/service/DesignerCommissionService.java | 모집 중 외주 목록 조회 서비스 추가 (status+pageable) |
| src/main/java/ditda/backend/domain/commission/core/repository/CommissionRepository.java | findByStatus(…, Pageable) 메서드 추가 |
| src/main/java/ditda/backend/domain/commission/core/mapper/CommissionMapper.java | Commission Page → CommissionListResponse 변환 매퍼 추가 |
| src/main/java/ditda/backend/domain/commission/core/facade/DesignerCommissionFacade.java | 디자이너 조회 + 모집중 외주 조회를 결합한 파사드 추가 |
| src/main/java/ditda/backend/domain/commission/core/entity/enums/CommissionAmountPolicy.java | 디자이너 레벨별 기본/최대 금액 정책 enum 추가 |
| src/main/java/ditda/backend/domain/commission/core/dto/response/CommissionListResponse.java | 디자이너 외주 목록 조회 응답 DTO 추가 |
| src/main/java/ditda/backend/domain/commission/core/controller/DesignerCommissionController.java | 신규 GET API 엔드포인트 및 정렬 주입(applicationDeadline ASC, id ASC) 추가 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Warning Review limit reached
More reviews will be available in 49 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough디자이너 인증 기반의 Changes디자이너 모집 외주 목록 조회
Sequence Diagram(s)sequenceDiagram
participant Designer
participant DesignerCommissionController
participant DesignerCommissionFacade
participant DesignerService
participant DesignerCommissionService
participant CommissionRepository
participant CommissionMapper
participant CommissionAmountPolicy
Designer->>DesignerCommissionController: GET /api/v1/designers/commissions
DesignerCommissionController->>DesignerCommissionFacade: getRecruitingCommissionList(designerId, sortedPageable)
DesignerCommissionFacade->>DesignerService: getById(designerId)
DesignerService-->>DesignerCommissionFacade: Designer
DesignerCommissionFacade->>DesignerCommissionService: getRecruitingCommissions(pageable)
DesignerCommissionService->>CommissionRepository: findByStatus(RECRUITING, pageable)
CommissionRepository-->>DesignerCommissionService: Page<Commission>
DesignerCommissionService-->>DesignerCommissionFacade: Page<Commission>
DesignerCommissionFacade->>CommissionMapper: toCommissionListResponse(page, designer.level)
CommissionMapper->>CommissionAmountPolicy: from(designer.level)
CommissionAmountPolicy-->>CommissionMapper: baseAmount, maxAmount
CommissionMapper-->>DesignerCommissionFacade: CommissionListResponse
DesignerCommissionFacade-->>DesignerCommissionController: CommissionListResponse
DesignerCommissionController-->>Designer: ApiResponse<CommissionListResponse>
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/ditda/backend/domain/designer/exception/DesignerErrorCode.java`:
- Line 14: The DESIGNER_LEVEL_POLICY_NOT_FOUND error is currently mapped to a
404 in DesignerErrorCode, but it should be treated as a server-side 5xx
classification instead. Update the DESIGNER_LEVEL_POLICY_NOT_FOUND enum entry
to use an internal/server error HttpStatus and keep the existing error
code/message consistent, so the error is not reported as a client-side not-found
issue.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2b952022-5826-4c18-82b0-90997468abcd
📒 Files selected for processing (9)
src/main/java/ditda/backend/domain/commission/core/controller/DesignerCommissionController.javasrc/main/java/ditda/backend/domain/commission/core/dto/response/CommissionListResponse.javasrc/main/java/ditda/backend/domain/commission/core/entity/enums/CommissionAmountPolicy.javasrc/main/java/ditda/backend/domain/commission/core/facade/DesignerCommissionFacade.javasrc/main/java/ditda/backend/domain/commission/core/mapper/CommissionMapper.javasrc/main/java/ditda/backend/domain/commission/core/repository/CommissionRepository.javasrc/main/java/ditda/backend/domain/commission/core/service/DesignerCommissionService.javasrc/main/java/ditda/backend/domain/designer/exception/DesignerErrorCode.javasrc/main/java/ditda/backend/domain/designer/service/DesignerService.java
fervovita
left a comment
fervovita
left a comment
There was a problem hiding this comment.
리뷰가 늦어져서 죄송합니다...
아래의 코멘트 한번만 확인해주세요!!
|
|
||
| @Getter | ||
| @AllArgsConstructor | ||
| public enum CommissionAmountPolicy { |
There was a problem hiding this comment.
#60 에 CommissionPricePolicy를 이미 구현해 놓았는데,
카테고리에 따라서 가격이 달라지고도 하고 환불/정산 등의 계산 로직이 추가로 들어와야 하는데 이를 enum으로만 관리하기에는 확장성 면에서 무리가 있을 것 같습니다.
혹시 CommissionPricePolicy로 통일해서 구현해주실 수 있을까요...?
그렇게 되면 아마 CommissionMapper 없이 단순 from/of 정적 메소드로 변환이 가능할 것 같습니다..!
🚀 Related issue
Closes #55
#️⃣ Summary
🔧 Changes
/api/v1/designers/commissionsAPI 추가📸 Test Evidence
💬 Reviewer Notes
InstructorCommissionHistoryController와 같이 Pageable 정렬 정의하여 주입하는 방식으로 진행했습니다.Summary by CodeRabbit
New Features
Bug Fixes