Draft
Conversation
- Update ModifyNodeDialog to return selectedNodeType in onSuccess callback - Update DiscourseNodeUtil to use the returned nodeType when updating shape props - Update uiOverrides.tsx to use the selected node type from dialog - Update renderNodeTagPopup.tsx to handle new nodeType parameter This ensures that when a user changes the node type mid-creation (e.g., from Claim to Hypothesis), the resulting canvas node is created with the correct type instead of retaining the initial type. Co-authored-by: doantranghp2000 <doantranghp2000@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
trangdoan982
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Canvas node creation to correctly reflect the selected node type when changed mid-creation.
Previously, if a user changed the node type in the
ModifyNodeDialogduring creation (e.g., from Claim to Hypothesis), the Canvas shape's underlying type would not update, leading to a mismatch between the UI and the internal data. This change ensures the selected node type is propagated and used to create the correct Canvas shape.Linear Issue: ENG-1315