ENG-1274: Migrate feature flags by sid597 · Pull Request #684 · DiscourseGraphs/discourse-graph

sid597 · 2026-01-11T19:07:59Z

https://www.loom.com/share/cafa18f38454407f85b2f25da6a5180e

new checkbox component for feature flag get and set in props, migrate to block prop based settings

use getFeatureFlag()

rerender left sidebar on enable/disable

linear · 2026-01-11T19:08:02Z

ENG-1274 Add feature flags in settings

supabase · 2026-01-11T19:08:06Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-01-11T19:08:30Z

ENG-1274: Migrate feature flags #684 👈 (View in Graphite)
ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#688 )
ENG-1190 Replace existing roam-js components with blockProp based ones #689
ENG-1188: prod: pull watchers for prop based settings #682
ENG-1187: Prod: Implement get and set for block prop based settings #669
ENG-1189: Prod: Init block prop based schema #666
ENG-1330: zod schema for discourse relations #719
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 8 additional flags.

mdroidian

I was under the assumption that we were going to run both the legacy settings and new blockProps at the same time while the migration was happening. It looks like this PR is just migrating to the blockProps. When is the migration supposed to take place? How are we going to test it?

Also, please make sure to save all files with prettier before requesting review.

mdroidian · 2026-02-02T02:20:08Z

apps/roam/src/components/settings/utils/hooks.ts

+  key: keyof FeatureFlags,
+  value: boolean,
+): void => {
+  window.dispatchEvent(


Why do we need a pullWatch and a dispatchEvent? Why don't we go directly to the dispatchEvent and skip the pullWatch? I'm worried that we are adding additional infrastruction that is unnecessary.

mdroidian · 2026-02-02T02:28:14Z

apps/roam/src/components/canvas/DiscourseRelationShape/DiscourseRelationUtil.tsx

          editor.updateShapes([{ id: arrow.id, type: target.type }]);
        }
-        if (getSetting<boolean>(USE_REIFIED_RELATIONS, false)) {
+        if (getFeatureFlag("Reified Relation Triples")) {


It looks like this is only calling blockProp based settings? I was under the assumption that we were going to run both at the same time while the migration was happening.

mdroidian · 2026-02-02T02:31:03Z

apps/roam/src/components/settings/utils/pullWatchers.ts

-  // "Suggestive Mode Enabled": (newValue) => { ... },
-  // "Reified Relation Triples": (newValue) => { ... },
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  "Enable Left Sidebar": (newValue) => {


We've discussed the naming before, should be sentence case. #664 (review)

mdroidian · 2026-02-02T02:31:31Z

apps/roam/src/components/settings/AdminPanel.tsx

        onCancel={() => setIsInstructionOpen(false)}
-        confirmButtonText="Reload Graph"
-        cancelButtonText="Later"
+        confirmButtonText="Got it"


… to block prop based settings

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 12 additional flags in Devin Review.

devin-ai-integration · 2026-02-04T17:59:26Z

apps/roam/src/components/settings/utils/pullWatchers.ts

  return createCleanupFn(watches);
 };


🔴 Pull watchers for feature flags are never initialized

The setupPullWatchOnSettingsPage function is defined in pullWatchers.ts but is never called anywhere in the codebase. This means the feature flag change handlers will never be triggered.

Click to expand

Impact

When users toggle feature flags via the FeatureFlagPanel component:

setFeatureFlag is called (accessors.ts:277-286)

The block props are updated in Roam

But the pull watcher that should detect this change and call the handlers is never set up

emitFeatureFlagChange is never called

React components using useFeatureFlag hook won't re-render

Side effects like remountLeftSidebar(), unmountLeftSidebar(), initializeSupabaseSync(), and setSyncActivity() will never execute

Actual vs Expected

Actual: The feature flag handlers in pullWatchers.ts:96-121 are defined but never invoked because setupPullWatchOnSettingsPage is never called.

Expected: setupPullWatchOnSettingsPage should be called during plugin initialization (e.g., in index.ts) to set up the pull watchers that trigger the handlers when feature flags change.

Evidence

Searching the codebase shows setupPullWatchOnSettingsPage is only exported, never imported or called:

apps/roam/src/components/settings/utils/pullWatchers.ts:export const setupPullWatchOnSettingsPage = (

(Refers to lines 184-253)

Was this helpful? React with 👍 or 👎 to provide feedback.

sid597 · 2026-02-07T16:43:35Z

Closing because too many changes that we don't want to merge in main at this point

This was referenced Jan 11, 2026

ENG-1105: zod schema for all the settings #664

Merged

ENG-1189: Prod: Init block prop based schema #666

Merged

ENG-1187: Prod: Implement get and set for block prop based settings #669

Merged

sid597 mentioned this pull request Jan 11, 2026

ENG-1188: prod: pull watchers for prop based settings #682

Merged

sid597 changed the title ~~new checkbox component for feature flag get and set in props, migrate to block prop based settings~~ ENG-1274: Migrate feature flags Jan 11, 2026

sid597 marked this pull request as ready for review January 11, 2026 19:08

sid597 force-pushed the eng-1188-create-a-pull-watch-handler-on-the-settings-page-per-feature-prod branch from f11b47f to 10445e6 Compare January 11, 2026 19:54

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from ea615c9 to 95e291a Compare January 11, 2026 19:54

sid597 mentioned this pull request Jan 12, 2026

ENG-1272 Migrate all small global settings components #688

Open

sid597 changed the base branch from eng-1188-create-a-pull-watch-handler-on-the-settings-page-per-feature-prod to graphite-base/684 January 12, 2026 15:26

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 29817b9 to 9cd0a2c Compare January 12, 2026 15:26

sid597 force-pushed the graphite-base/684 branch from 10445e6 to 0fb7fc7 Compare January 12, 2026 15:26

sid597 changed the base branch from graphite-base/684 to eng-1190-replace-existing-roam-js-components-with-blockprop-based January 12, 2026 15:26

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from db18fd8 to 23cedec Compare January 17, 2026 18:16

sid597 force-pushed the eng-1190-replace-existing-roam-js-components-with-blockprop-based branch from 0fb7fc7 to 62b0359 Compare January 17, 2026 18:16

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 23cedec to 496a3ba Compare January 18, 2026 05:25

sid597 force-pushed the eng-1190-replace-existing-roam-js-components-with-blockprop-based branch from 62b0359 to 40379a1 Compare January 18, 2026 05:25

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 496a3ba to 0238148 Compare January 19, 2026 04:51

sid597 force-pushed the eng-1190-replace-existing-roam-js-components-with-blockprop-based branch from 40379a1 to ac5f761 Compare January 19, 2026 04:51

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 0238148 to 8dbd24c Compare January 19, 2026 05:01

sid597 force-pushed the eng-1190-replace-existing-roam-js-components-with-blockprop-based branch from a671592 to 6e0130f Compare January 20, 2026 16:06

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 77d1c95 to 0d233ba Compare January 20, 2026 16:06

sid597 mentioned this pull request Jan 20, 2026

ENG-1330: zod schema for discourse relations #719

Merged

sid597 changed the base branch from eng-1190-replace-existing-roam-js-components-with-blockprop-based to graphite-base/684 January 26, 2026 07:01

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 0d233ba to cf49c4c Compare January 28, 2026 20:34

sid597 force-pushed the graphite-base/684 branch from 6e0130f to 050f93b Compare January 28, 2026 20:34

sid597 changed the base branch from graphite-base/684 to eng-1190-replace-existing-roam-js-components-with-blockprop-based January 28, 2026 20:34

devin-ai-integration bot reviewed Jan 28, 2026

View reviewed changes

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from cf49c4c to 122fce8 Compare January 28, 2026 20:55

sid597 requested a review from mdroidian January 28, 2026 20:56

mdroidian requested changes Feb 2, 2026

View reviewed changes

sid597 changed the base branch from eng-1190-replace-existing-roam-js-components-with-blockprop-based to graphite-base/684 February 3, 2026 16:51

sid597 mentioned this pull request Feb 3, 2026

ENG-1345: Modify existing RoamJS component onChange to also change props #745

Merged

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from 122fce8 to fcfa83f Compare February 3, 2026 18:56

sid597 force-pushed the graphite-base/684 branch from 050f93b to c022156 Compare February 3, 2026 18:56

sid597 changed the base branch from graphite-base/684 to eng-1345-modify-existing-roamjs-component-onchange-to-also-change February 3, 2026 18:57

sid597 changed the base branch from eng-1345-modify-existing-roamjs-component-onchange-to-also-change to graphite-base/684 February 4, 2026 17:17

sid597 added 6 commits February 4, 2026 23:25

new checkbox component for feature flag get and set in props, migrate…

08b3adf

… to block prop based settings

use getFeatureFlag()

219b066

rerender left sidebar on enable/disable

ba1773d

fix component location

c6b2937

make feature flags fully reactive

42bce3a

fix

1adcb4e

sid597 force-pushed the graphite-base/684 branch from c022156 to cf56730 Compare February 4, 2026 17:56

sid597 force-pushed the eng-1274-add-feature-flags-in-settings branch from fcfa83f to 1adcb4e Compare February 4, 2026 17:56

sid597 changed the base branch from graphite-base/684 to eng-1345-modify-existing-roamjs-component-onchange-to-also-change February 4, 2026 17:57

devin-ai-integration bot reviewed Feb 4, 2026

View reviewed changes

sid597 changed the base branch from eng-1345-modify-existing-roamjs-component-onchange-to-also-change to graphite-base/684 February 4, 2026 18:05

sid597 closed this Feb 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENG-1274: Migrate feature flags#684

ENG-1274: Migrate feature flags#684
sid597 wants to merge 6 commits intographite-base/684from
eng-1274-add-feature-flags-in-settings

sid597 commented Jan 11, 2026 •

edited

Loading

Uh oh!

linear bot commented Jan 11, 2026

Uh oh!

supabase bot commented Jan 11, 2026

Uh oh!

sid597 commented Jan 11, 2026 •

edited

Loading

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

mdroidian left a comment

Uh oh!

mdroidian Feb 2, 2026

Uh oh!

mdroidian Feb 2, 2026

Uh oh!

mdroidian Feb 2, 2026

Uh oh!

mdroidian Feb 2, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Feb 4, 2026

Uh oh!

sid597 commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sid597 commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jan 11, 2026

Uh oh!

supabase bot commented Jan 11, 2026

Uh oh!

sid597 commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

mdroidian Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Feb 4, 2026

Choose a reason for hiding this comment

Impact

Actual vs Expected

Evidence

Uh oh!

sid597 commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Jan 11, 2026 •

edited

Loading

sid597 commented Jan 11, 2026 •

edited

Loading