Move to using Local date instead of UTC date for UI, with fallback#195
Open
jaysonmaw wants to merge 3 commits intoDioxusLabs:mainfrom
Open
Move to using Local date instead of UTC date for UI, with fallback#195jaysonmaw wants to merge 3 commits intoDioxusLabs:mainfrom
jaysonmaw wants to merge 3 commits intoDioxusLabs:mainfrom
Conversation
- Fix: Calender / Date Picker opening to previous/next month depending on timezone - Fix: Calender highlighting previous/next day as today depending on timezone
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-195/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI "Today" dates should be based of the local users date not UTC.
Requires enabling
"local-offset"feature on time crateAlso includes a small extension method to encapsulate the fallback logic as well just to keep prop setters from getting a bit unwieldly, figure it is probably used enough to be worth it. rather than copying that everywhere.
(This can be tested with the Sensor tab in devtools, changing the location to one that is currently on a different day than UTC)