fix: normalize Windows workspace namespace paths#572
fix: normalize Windows workspace namespace paths#572Reekin wants to merge 3 commits intoDimillian:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b02e9da878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src-tauri/src/storage.rs
Outdated
| if changed { | ||
| try_rewrite_workspaces_with_normalized_paths(path, &list); |
There was a problem hiding this comment.
Stop retrying path migration on every workspace read
When read_workspaces sees a namespace path, it now rewrites the file on every read. In daemon mode, list_workspaces calls sync_workspaces_from_storage each request, which calls read_workspaces; if workspaces.json is read-only, changed stays true and this branch will keep attempting (and logging) a failed write on every refresh. That creates persistent stderr noise and avoidable I/O in the exact scenario this change aims to tolerate (best-effort migration when files are not writable).
Useful? React with 👍 / 👎.
Summary
\\?\workspace paths across workspace creation, storage, and worktree flowsTesting
rustfmt --edition 2021 src-tauri/src/storage.rs src-tauri/src/shared/settings_core.rs src-tauri/src/shared/workspaces_core/crud_persistence.rs src-tauri/src/shared/workspaces_core/helpers.rs src-tauri/src/shared/workspaces_core/worktree.rs src-tauri/src/workspaces/tests.rsgit diff --checknpm run test -- src/features/workspaces/hooks/useWorkspaces.test.tsx(blocked:vitestnot installed in current environment)npm run typecheck(blocked:tscnot installed in current environment)cargo test --manifest-path src-tauri/Cargo.toml ...(blocked by existing third-partywhisper-rs 0.12.0compile errors in this environment)