AGT-803-Deprecated-GAM-methods-module#67
Open
oleksii-intent wants to merge 2 commits into0.35-masterfrom
Open
Conversation
modules/intentIqIdSystem.js
Outdated
| .pubads() | ||
| .setTargeting(gamParameterName, userGroup); | ||
| if (typeof gamObjectReference.setConfig === 'function') { | ||
| const currentConfig = typeof gamObjectReference.getConfig === 'function' |
Owner
There was a problem hiding this comment.
Why do you decided to get config? We don't really care about other configurations in GAM, our main goal is to set ours. Pls check a case when only setConfig is using, from what I remember when we checked page together, it doesn't effect other targeting parameters in GAM.
modules/intentIqIdSystem.js
Outdated
| return; | ||
| } | ||
| const pubads = gamObjectReference?.pubads?.(); | ||
| if (pubads?.setTargeting) pubads.setTargeting(gamParameterName, userGroup); |
Owner
There was a problem hiding this comment.
Pls add comment here:
"Fallback in case an older version of Google Publisher Tag is used."
And code could be more compact:
gamObjectReference?.pubads?.()?.setTargeting?.(gamParameterName, userGroup);
Owner
|
@oleksii-intent There are much more places where our modules use GAM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information