Make "plugins" CLI option usable on Matomo install#57
Open
mbrodala wants to merge 1 commit into
Open
Conversation
This actually allows using this option to define the list of plugins to activate. Before the "PluginsInstalled" config option had a higher priority and the CLI option was only used if the config option was empty. And this is impossible: even if not defined in config.ini.php or common.config.ini.php, there is always the list from Matomo's global.ini.php which cannot be cleared. This is fixed now by processing the CLI option before the config option. Processing of the install file first is left unchanged. See https://github.com/matomo-org/matomo/blob/0ab4a4b4dae07ddc4d98ac06c703aa0118b22891/config/global.ini.php#L1285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually allows using this option to define the list of plugins to activate. Before the "PluginsInstalled" config option had a higher priority and the CLI option was only used if the config option was empty. And this is impossible: even if not defined in config.ini.php or common.config.ini.php, there is always the list from Matomo's global.ini.php which cannot be cleared.
This is fixed now by processing the CLI option before the config option. Processing of the install file first is left unchanged.
See https://github.com/matomo-org/matomo/blob/0ab4a4b4dae07ddc4d98ac06c703aa0118b22891/config/global.ini.php#L1285