Fix incorrect negative lookahead pattern#79
Open
forivall wants to merge 1 commit into
Open
Conversation
seems like you had based the syntax on a jsdoc syntax and missed this? idk. anyways, this works.
Author
|
I finally fixed my issues with the following gist: https://gist.github.com/forivall/d6a1fbc1ca902670ad51973b974ac177 - does what #71 does, although it doesn't highlight the html, but that's good enough for me. |
Member
|
@forivall I know this is really late. Sorry! Can you show me the output of both versions so that I can see exactly what this fixes? |
forivall
commented
Feb 10, 2023
| "contentName":"source.js", | ||
| "name": "meta.block.ejs", | ||
| "begin":"(<[%?](?:(?!php))[%_=-]?)(?!(\\s*\\*\/))", | ||
| "begin":"(<[%?](?:(?!php))[%_=-]?)(?!([_-]?[%?]>))", |
Author
There was a problem hiding this comment.
Suggested change
| "begin":"(<[%?](?:(?!php))[%_=-]?)(?!([_-]?[%?]>))", | |
| "begin":"(<[%?](?:(?!php))[%_=-]?)(?!([^%]*?[_-]?[%?]>))", |
Author
|
Looking at the old code i was working on, it looks like the situation was ejs inside of an html attribute - for example: <a href="<%= data.link.url %>">some text here, will still be "javascript" scope without this change</a> still javascript here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems like you had based the syntax on a jsdoc syntax and missed this? idk. anyways, this works.