feat: Add EJS support to Markdown [WIP]#44
Draft
ExE-Boss wants to merge 1 commit into
Draft
Conversation
Member
|
I know this is a work in progress, I tried to test it. I am unsure, this is really functioning though. Without the updated files I see the following: As you can see, it looks exactly like your pictures. I think for this to work, you will need to hijack the html interpreter and force it to use our extension first. I could be wrong, and if I am keep at it. I am all for this working everywhere. If this does work, it can be applied to many other languages as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this currently only highlights EJS tags and not HTML tags:
It also doesn’t close the code block correctly when a callback function has HTML inside it:
The latter is arguably worse in Markdown, as it completely breaks syntax highlighting in the document for everything following the function. And in the document I’m using, that’s 150‑ish more lines of Markdown.