Skip to content

fix(deps): pin tmp/follow-redirects/ws via overrides (audit 16->12) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moscowchill merged 2 commits into from
Jun 4, 2026
Merged

fix(deps): pin tmp/follow-redirects/ws via overrides (audit 16->12) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c8fc6
fix(deps): pin tmp/follow-redirects/ws via overrides (clear 1 high + …
moscowchill Jun 3, 2026
0acef94
address review: bump override floors to resolved versions (ws ^8.21.0…
moscowchill Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 10 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,10 @@
},
"devDependencies": {
"solc": "^0.8.34"
},
"overrides": {
"tmp": "^0.2.7",
"follow-redirects": "^1.16.0",
"ws": "^8.21.0"
}
Comment on lines +32 to 36

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The overrides in package.json specify minimum versions that are lower than the secure versions resolved in package-lock.json:

  1. ws: The vulnerability fix is in 8.21.0 (as noted in the PR description), but the override allows ^8.20.1 which could resolve to a vulnerable version.
  2. follow-redirects: The fix is in 1.16.0, but the override allows ^1.15.12.
  3. tmp: The resolved version is 0.2.7, but the override allows ^0.2.6.

To ensure that npm always resolves to the secure, tested versions (even during future dependency updates or lockfile regeneration), please update the overrides to match the minimum secure versions.

Suggested change
"overrides": {
"tmp": "^0.2.6",
"follow-redirects": "^1.15.12",
"ws": "^8.20.1"
}
"overrides": {
"tmp": "^0.2.7",
"follow-redirects": "^1.16.0",
"ws": "^8.21.0"
}

}