fix(.life): runtime spec Part B uses correct v0.7 audit event names (post-#115 review)#116
Merged
Conversation
…post-#115 review) - B.7 row 'withdrawal_check' was a duplicate of the existing v0.7 'withdrawal_poll' event. Renamed to reuse the existing event and spelled out the v0.8 obligation that 'endpoint' + 'result' fields become required (rather than introducing a new event type). - 'turn_emitted' was a non-existent name; the v0.7 event is 'session_turn' (defined in §5). Replaced and expanded the existing event roster to be exhaustive so future readers can locate it. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny follow-up to #115 — fixes two audit-event name mismatches Devin Review caught after the merge:
turn_emitteddoes not exist. The v0.7 audit event vocabularyin §5 names it
session_turn. Implementers searching forturn_emittedwould find no definition and might mint a newevent type. Replaced and made the v0.7 event roster exhaustive
so future readers can locate it from Part B.
withdrawal_checkwas a duplicate of the existing v0.7withdrawal_poll. Re-used the existing event and made thev0.8 obligation explicit (Stage 5 Guard MUST populate
endpointand
result), rather than introducing a new event type thatshadows the existing one.
Changes
docs/LIFE_RUNTIME_STANDARD.md:withdrawal_pollevent with v0.8 field-required clarification.turn_emittedwithsession_turnand list every existing v0.7 event by name (
session_started,session_turn,session_withdrawn,session_terminated,forbidden_use_refused,disclosure_warning_emitted).CHANGELOG.md: appendix note (covered by the existing v0.8: docs/LIFE_RUNTIME_STANDARD.md update — 5-stage assembly + Provider Registry #105 entry —no separate bullet, since this is a clarification not a new
feature).
Local validation
python tools/batch_validate.py→ 21/21 steps pass (no schema or test changes).Review & Testing Checklist for Human
Risk: green — pure doc clarification fix. Two-line change.
docs/LIFE_RUNTIME_STANDARD.mdlines 285–293 containssession_turnandwithdrawal_poll(it does at master HEAD post-v0.8: docs/LIFE_RUNTIME_STANDARD.md — Part B Topic 4 (5-stage assembly) (#105) #115).Notes
Same follow-up pattern as #109 → #108, #112 → #110, and #114 → #111.
Closes the Devin Review finding BUG_pr-review-job-0d59d48f… on the merged #115.
Link to Devin session: https://app.devin.ai/sessions/ff7322e18fd94887875daa2c1c75f87d
Requested by: @LING71671