Remove requirement for episode number when guessing #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with some types of episodes, such as extras, the episode number will be missing, but the subtitle download succeeds with the check removed
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Collaborator
Author
|
ah, actually, sometimes it just pulls the first episode of the season... |
Collaborator
Collaborator
|
Are you still working on this? |
Collaborator
Author
|
to be fair, the other MR is flawed in the same way as mine is |
Collaborator
Author
|
but to answer your question, i forgot about it, but at some point i'd like to either fix it myself, or see it fixed ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with some types of episodes, such as extras, the episode number will be missing, but the subtitle download succeeds with the check removed