Advance RustCrypto pins to the current rc.18/rc.33/rc.10 cluster#692
Open
Sopleb (sopleb) wants to merge 1 commit into
Open
Advance RustCrypto pins to the current rc.18/rc.33/rc.10 cluster#692Sopleb (sopleb) wants to merge 1 commit into
Sopleb (sopleb) wants to merge 1 commit into
Conversation
Bump the exact-pinned RustCrypto release candidates in the sspi and dpapi manifests so they resolve alongside crates that have already moved to the newer cluster (e.g. russh 0.61): ecdsa 0.17.0-rc.17 -> 0.17.0-rc.18 (dpapi) elliptic-curve 0.14.0-rc.31 -> 0.14.0-rc.33 (dpapi) p256/p384/p521 0.14.0-rc.9 -> 0.14.0-rc.10 primeorder 0.14.0-rc.9 -> 0.14.0-rc.10 primefield 0.14.0-rc.9 -> 0.14.0-rc.12 rsa 0.10.0-rc.17 -> 0.10.0-rc.18 ed25519-dalek 3.0.0-pre.6 -> 3.0.0-rc.0 x25519-dalek 3.0.0-pre.6 -> 3.0.0-rc.0 (dpapi) curve25519-dalek 5.0.0-pre.6 -> 5.0.0-rc.0 Crates that have shipped stable releases drop the RC pin and track the stable line: ed25519, signature, pkcs8, ff, group, aead, pbkdf2, rfc6979. No source changes are required; sspi (with scard) and the full workspace build and tests pass. Note: sspi-ffi depends on published picky 7.0.0-rc.23, whose pins still target the older cluster, so the workspace resolves on crates.io only once the companion picky pin bump is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact-pinned RustCrypto release candidates in
sspianddpapilag the versions published and shared across the ecosystem, so they stop resolving next to crates that already moved (russh 0.61 pulls ecdsa 0.17.0-rc.18, elliptic-curve 0.14.0-rc.33, the p-curves at rc.10, rsa 0.10.0-rc.18, and the dalek rc.0 line). This advances the pins to that cluster.Cargo.tomlandcrates/dpapi/Cargo.toml:ed25519,signature,pkcs8,ff,group,aead,pbkdf2, andrfc6979have stable releases, so their pins drop the RC suffix and follow the stable line.The bump needs no source changes.
cargo build -p sspi --features scard,cargo test -p sspi --features scard, and the full workspace build pass on a 1.96 toolchain.One ordering note:
sspi-ffidepends on publishedpicky 7.0.0-rc.23, whose pins still target the older cluster. Until a picky release carries the matching bump (companion PR Devolutions/picky-rs#501), the workspace resolves from crates.io only with a local picky patch. The validation above used that patch.