fix(credssp): grammar in expect message + guard empty output token in PubKeyInfo path#690
Merged
Benoît Cortier (CBenoit) merged 3 commits intoJun 18, 2026
Merged
Conversation
…ken in PubKeyInfo path - Fix grammar: "an decrypt" → "a decrypt" in exchange_pub_key_auth expect message - Only advance to PubKeyInfo state when the output token is non-empty; if the token is empty and pub_key_auth is absent, return an InvalidToken error to match the original single-leg behaviour
Copilot
AI
changed the title
[WIP] Fix code for all comments in review thread
fix(credssp): grammar in expect message + guard empty output token in PubKeyInfo path
Jun 17, 2026
Member
|
Pavlo Myroniuk (@PavloMyroniuk-apriorit) Automatically fixed the Copilot feedback in the last PR merged |
Pavlo Myroniuk (TheBestTvarynka)
requested changes
Jun 18, 2026
Pavlo Myroniuk (TheBestTvarynka)
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review comments from PR #689.
Changes
Grammar fix:
"an decrypt"→"a decrypt"in theexpectmessage insideexchange_pub_key_authLogic fix: The
elsebranch in theOk/CompleteNeededacceptor path previously advanced unconditionally to the two-legPubKeyInfostate wheneverpub_key_authwas absent — even when the SSPI output token was empty. An empty token means there is nothing to forward to the client; sending emptynegoTokensand advancing state is incorrect. The fix gates the two-leg path on a non-empty token; an empty token falls back to the original single-leg error (requiringpubKeyAuthin the same TSRequest).