feat(dpapi): implement DPAPI#381
Merged
Merged
Conversation
MS-GKDI structures and DPAPI Blob encoding/decoding. Docs & references: * [[MS-GKDI]: Group Key Distribution Protocol](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-gkdi/943dd4f6-6b80-4a66-8594-80df6d2aad0a). * [jborean93/dpapi-ng](https://github.com/jborean93/dpapi-ng/tree/main).
The `crypto` module contains many _magic_ numbers. I took them from the Python DPAPI implementation: https://github.com/jborean93/dpapi-ng/blob/main/src/dpapi_ng/_crypto.py and https://github.com/jborean93/dpapi-ng/blob/main/src/dpapi_ng/_gkdi.py. Docs & references: * [[MS-GKDI]: Group Key Distribution Protocol](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-gkdi/943dd4f6-6b80-4a66-8594-80df6d2aad0a). * [jborean93/dpapi-ng](https://github.com/jborean93/dpapi-ng/tree/main).
Pavlo Myroniuk (TheBestTvarynka)
force-pushed
the
dev/dpapi
branch
2 times, most recently
from
ec0b98a to
4ce3873
Compare
Pavlo Myroniuk (TheBestTvarynka)
force-pushed
the
dev/dpapi
branch
from
4ce3873 to
f0c97e4
Compare
Pavlo Myroniuk (TheBestTvarynka)
requested a review
from Benoît Cortier (CBenoit)
Pavlo Myroniuk (TheBestTvarynka)
marked this pull request as ready for review
Benoît Cortier (CBenoit)
approved these changes
Feb 27, 2025
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
Member
There was a problem hiding this comment.
Here we go! Great work, thank you! 🎉
Benoît Cortier (CBenoit)
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR contains the DPAPI implementation. Refer to the following PRs for more details:
SECBUFFER_READONLY_WITH_CHECKSUMflag support #357USE_DCE_STYLEflag support #358rust-kbkdfwithkbkdfcrate #371closes #120, #121
cc Marc-André Moreau (@awakecoding)