fix(agent): add RDM multi-instance support for Jump messages#1669
Merged
vnikonov-devolutions merged 3 commits intomasterfrom Feb 3, 2026
Merged
fix(agent): add RDM multi-instance support for Jump messages#1669vnikonov-devolutions merged 3 commits intomasterfrom
vnikonov-devolutions merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
CI: GitHub actions runners are unwell |
CBenoit
reviewed
Feb 3, 2026
| .prefix("devolutions-session-rdm") | ||
| .suffix(".pid") | ||
| .rand_bytes(0) | ||
| // Keep file after drop, while still removing on reboot on Windows. |
Member
There was a problem hiding this comment.
question: Why do we need to keep it after drop?
Contributor
Author
There was a problem hiding this comment.
Because this file should persist between devolutions-session launched (re-starts on every RDP reconnection), see find_rdm_pid doc comment
Contributor
Author
There was a problem hiding this comment.
I am mainly interested in tempfile logic which removes file on reboot for Windows (temo files are persistent on Windows by default)
Member
There was a problem hiding this comment.
Would you agree with updating the comment like this?
// Keep file after drop so the PID hint persists across devolutions-session
// restarts (which occur on every RDP reconnection). See `find_rdm_pid` doc
// comment. The file is still cleaned up on Windows reboot since it resides
// in the system temp directory.
CBenoit
reviewed
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RDM multi-instance support for Jump messages (separate named pipe for each RDM instance in session)
Issue: RDMW-21183