Skip to content

fix: correct import path in tracker.py from Eagle.libs.config to libsconfig.settings#109

Open
Ryzen-Starbit wants to merge 1 commit into
Devnil434:mainfrom
Ryzen-Starbit:fix/tracker-import-path
Open

fix: correct import path in tracker.py from Eagle.libs.config to libsconfig.settings#109
Ryzen-Starbit wants to merge 1 commit into
Devnil434:mainfrom
Ryzen-Starbit:fix/tracker-import-path

Conversation

@Ryzen-Starbit
Copy link
Copy Markdown
Contributor

@Ryzen-Starbit Ryzen-Starbit commented May 24, 2026

Fixes #99

What this PR does

Corrects the import path in services/tracking/tracker.py line 21.
Old: from Eagle.libs.config import settings
New: from libs.config.settings import settings
Every other file in the project uses the correct relative import. This incorrect path was causing ModuleNotFoundError for all 22
tests in test_cross_camera_reid.py.

Files changed

  • services/tracking/tracker.py (line 21 only)

Summary by CodeRabbit

  • Chores
    • Updated internal import paths for configuration management.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6d607bb3-2666-4962-b887-7665a6852243

📥 Commits

Reviewing files that changed from the base of the PR and between f282de7 and f5445e0.

📒 Files selected for processing (1)
  • services/tracking/tracker.py

📝 Walkthrough

Walkthrough

This PR corrects an import path in services/tracking/tracker.py from Eagle.libs.config to libs.config.settings, matching the project's established import convention and restoring test execution.

Changes

Configuration Import Fix

Layer / File(s) Summary
Settings import correction
services/tracking/tracker.py
The import statement on line 21 is corrected from from Eagle.libs.config import settings to from libs.config.settings import settings to align with the project's relative import pattern.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A path misplaced, a typo small,
Now Eagle flies no more, no call!
From lib's own home, settings return,
Tests may pass—their lesson learned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: correcting an import path in tracker.py from an incorrect path to the correct one.
Linked Issues check ✅ Passed The pull request fully addresses the requirement in issue #99: it corrects the import path in services/tracking/tracker.py line 21 from 'Eagle.libs.config' to 'libs.config.settings', resolving the ModuleNotFoundError that broke the test suite.
Out of Scope Changes check ✅ Passed The pull request contains only the required one-line import fix in services/tracking/tracker.py; no unrelated or out-of-scope changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ryzen-Starbit
Copy link
Copy Markdown
Contributor Author

Hi @Devnil434, the CI failure is now at line 22 (cv2) instead of line 21 (Eagle.libs.config), confirming the import path fix is working correctly cv2 is a separate missing package unrelated to this fix.
Could you also add the gssoc:approved label to this PR, Issue #99 and PR #93 (merged 5 days ago)? All three are
missing the label. Thanks!

@kunal-9090
Copy link
Copy Markdown

I checked the failing Phase 3 CI for this PR. The latest failure was no longer the import path itself; ests/test_memory.py imports services.memory, but services/init.py eagerly imports tracking, which pulls optional video/tracking deps (cv2, DeepSort) into the memory-only test job.\n\nI prepared a fix branch here: https://github.com/kunal-9090/Eagle/tree/codex/fix-pr-109-ci\n\nFix included:\n- keep rom libs.config.settings import settings in services/tracking/tracker.py\n- stop eager importing tracking from services/init.py so Phase 3 memory tests do not require tracking dependencies\n\nLocal verification: python -m ruff check services/memory/ libs/schemas/memory.py services/init.py services/tracking/tracker.py passes. I could not push directly to this contributor fork; GitHub returned 403 for kunal-9090.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tracker.py uses incorrect import path 'from Eagle.libs.config' - breaks entire CI test suite

3 participants