fix: correct import path in tracker.py from Eagle.libs.config to libsconfig.settings#109
fix: correct import path in tracker.py from Eagle.libs.config to libsconfig.settings#109Ryzen-Starbit wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR corrects an import path in ChangesConfiguration Import Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Devnil434, the CI failure is now at line 22 (cv2) instead of line 21 (Eagle.libs.config), confirming the import path fix is working correctly cv2 is a separate missing package unrelated to this fix. |
|
I checked the failing Phase 3 CI for this PR. The latest failure was no longer the import path itself; ests/test_memory.py imports services.memory, but services/init.py eagerly imports tracking, which pulls optional video/tracking deps (cv2, DeepSort) into the memory-only test job.\n\nI prepared a fix branch here: https://github.com/kunal-9090/Eagle/tree/codex/fix-pr-109-ci\n\nFix included:\n- keep rom libs.config.settings import settings in services/tracking/tracker.py\n- stop eager importing tracking from services/init.py so Phase 3 memory tests do not require tracking dependencies\n\nLocal verification: python -m ruff check services/memory/ libs/schemas/memory.py services/init.py services/tracking/tracker.py passes. I could not push directly to this contributor fork; GitHub returned 403 for kunal-9090. |
Fixes #99
What this PR does
Corrects the import path in services/tracking/tracker.py line 21.
Old: from Eagle.libs.config import settings
New: from libs.config.settings import settings
Every other file in the project uses the correct relative import. This incorrect path was causing ModuleNotFoundError for all 22
tests in test_cross_camera_reid.py.
Files changed
Summary by CodeRabbit